Skip to content

bpo-36729: Delete unused text variable on tests#12959

Merged
serhiy-storchaka merged 2 commits into
python:masterfrom
eamanu:delete-unused-variables
Apr 29, 2019
Merged

bpo-36729: Delete unused text variable on tests#12959
serhiy-storchaka merged 2 commits into
python:masterfrom
eamanu:delete-unused-variables

Conversation

@eamanu

@eamanu eamanu commented Apr 26, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

On test_custom_non_data_descriptor and
test_custom_data_descriptor there was a text variable
not used. This PR remove it.

I think that is not necessary NEWS here.

https://bugs.python.org/issue36729

@eamanu
Delete unused text variable on tests
0d9b74e 
On ```test_custom_non_data_descriptor``` and
```test_custom_data_descriptor``` there was a text variable
not used. This PR remove it.

I think that is not necessary NEWS here.
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Apr 26, 2019
@eamanu eamanu changed the title Delete unused text variable on tests bpo-36729: Delete unused text variable on tests Apr 26, 2019
terryjreedy
terryjreedy previously requested changes Apr 27, 2019
View reviewed changes

@terryjreedy terryjreedy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fairly sure that current change is wrong, so that revision is a must.

Comment thread Lib/test/test_pydoc.py
@bedevere-bot

bedevere-bot commented Apr 27, 2019

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@tirkarthi

tirkarthi commented Apr 27, 2019

Copy link
Copy Markdown
Member

This was added in #11366

cc: @serhiy-storchaka

serhiy-storchaka
serhiy-storchaka reviewed Apr 27, 2019
View reviewed changes
Comment thread Lib/test/test_pydoc.py
@eamanu

eamanu commented Apr 28, 2019

Copy link
Copy Markdown
Contributor Author

HI @terryjreedy thanks for the review. Follow the @serhiy-storchaka comments I continue with this PR.

@terryjreedy terryjreedy dismissed their stale review April 29, 2019 01:07

Serhiy added more information

@terryjreedy

terryjreedy commented Apr 29, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

Getting more definitive info from the original author as how to proceed was perhaps my most important suggestion. I am glad you were able to do that.

@eamanu

eamanu commented Apr 29, 2019

Copy link
Copy Markdown
Contributor Author

Getting more definitive info from the original author as how to proceed was perhaps my most important suggestion. I am glad you were able to do that.

Yes, Thanks! :-)

@serhiy-storchaka serhiy-storchaka merged commit 86f0c82 into python:master Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@terryjreedy terryjreedy terryjreedy left review comments
+1 more reviewer
@auvipy auvipy auvipy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@eamanu @bedevere-bot @tirkarthi @terryjreedy @serhiy-storchaka @auvipy @berkerpeksag @the-knights-who-say-ni